Fix Resource#wait_until(max_attempts: nil) #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now retries indefinitely, instead of defaulting to 10 attempts.
ktheory
force-pushed
the
fix-resource-unlimited-attempts
branch
from
a5c961e
to
7fae8fa
Compare
|
Looks good to me, nice catch! 👍 I would be inclined to agree that this is the best way rather than special casing |
awood45
added a commit
that referenced
this pull request
Jun 26, 2015
Fix Resource#wait_until(max_attempts: nil)
awood45
added a commit
that referenced
this pull request
Jun 26, 2015
Adds release notes for pull request #855.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy Friday! 👋
I noticed that passing
max_attempts: nilto a resource didn't work like these docs said. It only tried 10 times before raisingAws::Waiters::Errors::TooManyAttemptsError. 🐛 🚨So I changed the code match the docs. 🎉 😌
Is there even a test???
You betcha. Of course it's weird to test that we actually attempt something indefinitely. So I just test that
wait_until(max_attempts: nil)attempts more than 10 times.Could there be another way???
Instead of changing the code, we could change the docs to recommend passing
max_attempts: -1or something instead. That can be a workaround until this is released. IMHO, usingnilinstead of-1to indicate "unlimited" seems more conventional for Rubyists.