Fix stubbing errors with 'query' protocol #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now you can do the following:
```
c = Aws::CloudFormation::Client.new(stub_responses: {validate_template:
'ValidationError'})
c.validate_template(template_body: '')
```
This used to return `nil`. Now it raises
Aws::CloudFormation::Errors::ValidationError like you’d expect.
|
Thanks, I'll merge this then DRY it up. |
trevorrowe
added a commit
that referenced
this pull request
Jul 21, 2015
Fix stubbing errors with 'query' protocol
trevorrowe
added a commit
that referenced
this pull request
Jul 21, 2015
|
Thanks, @trevorrowe. You rock! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this wasn't working:
The expected result is to raise an
Aws::CloudFormation::Errors::ValidationError. 🐛 🚨Turns out CloudFormation uses the
queryprotocol, and theAws::Stubbing::Protocols::Query#build_errormethod was blank.YOLO?
I literally copied the method from
RestXml#stub_error. 🙀 There's probably a better way.There are no tests. 🙅