Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add credential_process support #317

Closed
tahoward opened this issue Feb 27, 2019 · 9 comments
Closed

Add credential_process support #317

tahoward opened this issue Feb 27, 2019 · 9 comments
Labels
feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@tahoward
Copy link

Is your feature request related to a problem? Please describe.
For Enterprises using SAML based authentication against AWS through services like Okta there is no seamless fully integrated way to assume a role in AWS using AWS VS Toolkit.

Describe the solution you'd like
Support for interpreting a profile's credential_process parameter in ~/.aws/credentials

Please see:

Describe alternatives you've considered
Using a scheduled task to run external process for refreshing session token and injecting a static profile into ~/.aws/credentials.

I did a cursory glance but did not identify if this is built on top of aws-sdk-net. If so I'll submit the appropriate feature request there as well.
@awschristou awschristou added feature-request New feature or enhancement. May require GitHub community feedback. blocked waiting on third party / upstream / external labels Feb 27, 2019
@awschristou
Copy link
Contributor

Thank you for the request @tahoward , the Toolkit for VS Code is developed in Typescript, currently using V2 of the AWS SDK for Javascript. The SDK does not appear to support credential_process at this time.

@awschristou
Copy link
Contributor

@tahoward I had a chat with someone from the JS SDK team. It sounds like credential_process support is being looked into. If/when it is released into the SDK, we will be able to investigate further for the Toolkit.

@tahoward
Copy link
Author

tahoward commented Feb 28, 2019 •
edited
Loading

@awschristou Thanks for looking into it!

@MetricMike
Copy link

Just wanted to ping that credential_process was released with v2.429.0 this week.

@mpiroc
Copy link
Contributor

mpiroc commented May 8, 2019

If I understand correctly, all that we need to do is bump our dependency on aws-sdk to >2.429.0, and we will get credential_process support for free.

@mpiroc mpiroc changed the title Support for Credential Process Add credential_process support May 9, 2019
@MetricMike
Copy link

That's my understanding as well, though the current requirement in package.json is just on the major version, so a build/release should be all that's needed.

@mpiroc mpiroc added this to the Sprint 22 milestone May 24, 2019
@bryceitoc9
Copy link
Contributor

Took a quick look and we'll need to refactor our credential handling--right now, we're handling credentials rather than profiles. This change should be relatively quick once we move to profile handling.

@mpiroc mpiroc removed this from the Sprint 22 milestone May 31, 2019
@bryceitoc9 bryceitoc9 mentioned this issue Jul 29, 2019
Closed
lloydmarkle added a commit to lloydmarkle/aws-toolkit-vscode that referenced this issue Sep 4, 2019
@lloydmarkle
Update AWS sdk to >2.429.0 (aws#317)
d107938
lloydmarkle added a commit to lloydmarkle/aws-toolkit-vscode that referenced this issue Sep 4, 2019
@lloydmarkle
Load credentials from credential_process (aws#317)
084d113
lloydmarkle added a commit to lloydmarkle/aws-toolkit-vscode that referenced this issue Sep 4, 2019
@lloydmarkle
Update changelog (aws#317)
105ca2c
@lloydmarkle lloydmarkle mentioned this issue Sep 4, 2019
Merged
6 tasks
lloydmarkle added a commit to lloydmarkle/aws-toolkit-vscode that referenced this issue Sep 8, 2019
@lloydmarkle
Use credential provider chain and add tests (aws#317)
e40c522 
Add dependency on sinon to write tests
awschristou pushed a commit that referenced this issue Sep 12, 2019
@lloydmarkle @awschristou
Load AWS credentials from credential_process (#749)
87d04ce 
* Update AWS sdk to >2.429.0 (#317)
* Load credentials from credential_process (#317)
* Use credential provider chain and add tests (#317)
* Add dependency on sinon to write tests
@awschristou
Copy link
Contributor

@tahoward @MetricMike A change that introduces support for credential_process has just been merged to the master branch. If you have a chance to build the extension from source and try it out, we'd be interested in hearing if it works for you.

@awschristou awschristou added needs-response Waiting on reply from issue/PR author. and removed blocked waiting on third party / upstream / external needs-design labels Sep 12, 2019
@awschristou
Copy link
Contributor

Today version 1.1.0 of the Toolkit has been released, which includes credential_process support.

@awschristou awschristou removed the needs-response Waiting on reply from issue/PR author. label Sep 23, 2019
@garthk garthk mentioned this issue Dec 14, 2019
Closed
@garthk garthk mentioned this issue Dec 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@MetricMike @tahoward @mpiroc @bryceitoc9 @awschristou