deps: replace "nyc" with "c8" #4228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it worked: https://app.codecov.io/github/aws/aws-toolkit-vscode/commit/bc308d44c8cca822ed4a982195175c8adc6b70fa |
hayemaxi
reviewed
Jan 4, 2024
| "report-dir": "./coverage", | ||
| "reporter": ["lcov"], | ||
| "all": true, | ||
| "include": ["src/**", "dist/src/**"], |
There was a problem hiding this comment.
should we check the lint rules in plugins/ as well?
There was a problem hiding this comment.
Sure, let's add that later.
hayemaxi
approved these changes
Jan 4, 2024
Problem: `nyc` is no longer maintained: istanbuljs/nyc#1514 and it depends on various outdated packages, .e.g `uuid@3.4.0` (check with `npm ls uuid`). Solution: - Remove `nyc`. - Migrate to `c8`.
justinmk3
commented
Jan 5, 2024
| "all": true, | ||
| "include": ["src/**", "dist/src/**"], | ||
| "exclude": [ | ||
| "dist/src/ssmDocument/ssm/ssmServer.js", |
There was a problem hiding this comment.
Avoid this weird failure from somewhere in ssmDocument/** :
Error: ENOENT: no such file or directory, open 'D:\a\aws-toolkit-vscode\aws-toolkit-vscode\coverage\lcov-report\dist\src\ssmDocument\external "buffer".html'
at Object.openSync (node:fs:590:3)
at FileWriter.writeFile (D:\a\aws-toolkit-vscode\aws-toolkit-vscode\node_modules\istanbul-lib-report\lib\file-writer.js:185:41)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
nycis no longer maintained: istanbuljs/nyc#1514and it depends on various outdated packages, .e.g
uuid@3.4.0(check withnpm ls uuid).Solution
nyc.c8.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.