Don't floor custom start/end timestamps. #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srprash
approved these changes
Jan 28, 2020
enif-lee
pushed a commit
to enif-lee/aws-xray-sdk-dotnet
that referenced
this pull request
Sep 11, 2020
Fixes aws#118 This affects only ASP .Net applications and not .Net Core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#118
Description of changes:
Removes the
decimal.Flooroperation performed on the start/end timestamps as described in the issue #118. Adds test cases to ensure precision down to 1ms.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.