Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing Support for Entity Framework Core 3.0 and above #124

Merged
merged 5 commits into from
Apr 9, 2020
Merged

Tracing Support for Entity Framework Core 3.0 and above #124

merged 5 commits into from
Apr 9, 2020

Conversation

srprash
Copy link
Collaborator

@srprash srprash commented Mar 24, 2020

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lupengamzn lupengamzn self-requested a review March 24, 2020 19:44
@lupengamzn lupengamzn changed the title Ef core support Tracing Support for Entity Framework Core 3.0 and above Mar 24, 2020
Copy link
Collaborator Author

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lupengamzn Some minor comments. Otherwise the PR looks good!

sdk/src/Handlers/EntityFramework/EFUtil.cs Outdated Show resolved Hide resolved
sdk/test/UnitTests/EfCoreTests.cs Show resolved Hide resolved
@emonhaider
Copy link

@srprash I see this is merged to master, was the nuget published?

@lupengamzn
Copy link
Contributor

Hi @emonhaider, the Nuget will be published soon in this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants