feat(HttpClient): Provide tracing handler to allow removal of query string in traces #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… string from traces
|
Thanks @AnuragMohapatra for contributing the future. It would have been ideal if we could have made the query sanitization the default behavior, but I believe that could be a backwards incompatible for some customers. So this looks good to me. :) |
srprash
approved these changes
Aug 13, 2022
|
Thanks @srprash One more reason for the separate instance is to give the ability to have different httpmessagehandler on different named client which may(I have not test) allow the user to have a peek on some query strings if required for troubleshooting or debugging. That was my thought process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #201
Issue #, if available:
Description of changes:
Added a new Tracing handler that will configure the httpmessagehandler in a way that when it adds traces to XRay recorder it will strip the query parameters around it and on trace the path.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.