Custom timestamp for subsegment #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto custom_timestamp_for_subsegment_2
srprash
changed the title
yogiraj07
suggested changes
Jul 15, 2019
| @@ -1052,6 +1052,35 @@ public void TestDefaultStreamingStrategyWithNegativeValue() | |||
| Assert.ThrowsException<ArgumentException>(() => new AWSXRayRecorderBuilder().WithStreamingStrategy(new DefaultStreamingStrategy(-100))); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| public void TestBeginSubsegmentWithCustomTime() | |||
There was a problem hiding this comment.
Sanity check : unit test that checks begin/end subsegment if no value is passed? The assertion should be on the current time.
yogiraj07
reviewed
Jul 15, 2019
yogiraj07
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 76
Description of changes:
Added timestamp parameter to BeginSubsegment and EndSubsegment.
Added Unit tests for the same.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.