Improves reservoir to avoid a race condition and to be more fair #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This re-uses the implementation we just made in Brave based on feedback on yours. Enjoy! See openzipkin/brave#819
|
sorry had a bug. should be ok now cc @abhiksingh |
|
build fail looks like a flake |
|
@adriancole thanks for the fix and a more fair reservoir implementation. The team is reviewing the code and we will look to merge this in at the earliest. |
|
Hi @adriancole, I have created an issue for the flaky unit test. It is not related to this PR. The re-run build passed and I'm merging this in. Thank you for your contribution we really appreciate it. |
haotianw465
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-uses the implementation we just made in Brave based on feedback
on yours. Enjoy!
See openzipkin/brave#819