Remove the dependency on requests #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the use of `requests` from the core functionality, which results in `requests` being only used as extension, therefore not being necessary as dependency anymore. The motivation for this change is to get rid of all the dependencies of `requests`, whose size sums up quite a bit, when not requiring to patch `requests`. It follows the removal of `requests` from `botocore`, which was done as part of v1.11.0.
haotianw465
approved these changes
Nov 8, 2018
|
Thank you for your contribution. I have merged this PR and it will be out with our next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the use of
requestsfrom the core functionality, whichresults in
requestsbeing only used as extension, therefore not beingnecessary as dependency anymore.
The motivation for this change is to get rid of all the dependencies of
requests, whose size sums up quite a bit, when not requiring to patchrequests. It follows the removal ofrequestsfrombotocore, whichwas done as part of v1.11.0.
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.