Add patch support for pg8000 (Pure python driver) #115
Conversation
tests/ext/psycopg2/test_psycopg2.py
Outdated
| @@ -39,7 +39,7 @@ def test_execute_dsn_kwargs(): | |||
| cur = conn.cursor() | |||
| cur.execute(q) | |||
|
|
|||
| subsegment = xray_recorder.current_segment().subsegments[0] | |||
| subsegment = xray_recorder.current_segment().subsegments[-1] | |||
There was a problem hiding this comment.
Thank you for the contribution. I have one question. This test setup explicitly patches only psycopg2 in line 12. How does this get impacted? You can refer httplib patcher where it has unpatch method so for test teardown it restores the original httplib to avoid impacting other libraries depending on it: https://github.com/aws/aws-xray-sdk-python/blob/master/aws_xray_sdk/ext/httplib/patch.py#L168-L178. It's also required that double instrumentation is not the default for customers running patch_all. You can check the logic here: https://github.com/aws/aws-xray-sdk-python/blob/master/aws_xray_sdk/core/patcher.py#L30-L34
There was a problem hiding this comment.
Thanks for noticing! Fixed in the latest revision.
There was a problem hiding this comment.
Thank you. I've merged it and will roll it out in our next release.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.