Fix httplib invalid scheme detection for HTTPS (#121). #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Libraries utilizing urllib3 now properly get matched as https when an https request is made.
+ botocore and requests utilize urllib3, so any underlying https request now properly
identifies as https.
haotianw465
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes misidentification of https requests as http requests in the segment metadata. This was caused by the patcher intercepting urllib3 HTTPS connections vs httplib HTTPS connections.
Issue #, if available:
#121
Description of changes:
Check if the connection instance is a subclass of httplib's https connection class or urllib3's https connection class.
Botocore3 and requests utilizes urllib3 for HTTPS, so incorrect URLs were being published to the subsegment http metadata for AWS API calls as well as Requests calls.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.