Fixes unit test for newer versions of psycopg2. #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 2.8.0 of Psycopg2 introduces more granular errors for queries. This commit fixes a unit test to assert on the specific error instead of the now-updated base class. The previous matching class was ProgrammingError. For the specific test, it is now UndefinedColumn, which is a subclass of ProgrammingError.
yogiraj07
approved these changes
Jun 13, 2019
|
Sanity check : Do we need to do modification in AWS SDK handler w.r.t to this change? |
|
Nope this was a pure test error. Basically, Psycopg2 was updated so that they have more exceptions, so the only change that this'll do is that there are more types of exceptions that can be caught and stored in the segment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.8.0 of Psycopg2 introduces granular errors for queries. This commit fixes a unit test to assert on the specific error instead of the now-updated base class. Functionally, the patcher still works fine with the latest versions of Psycopg2.
The previous matching class was ProgrammingError. For the specific test, it is now UndefinedColumn, which is a subclass of ProgrammingError.
Issue #, if available:
#159
Description of changes:
Modified test to check for UndefinedColumn instead of ProgrammingError.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.