Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist SageMakerRuntime InvokeEndpoint operation #183

Merged
merged 2 commits into from
Nov 19, 2019

Conversation

jknollmeyer
Copy link
Contributor

Operation name and request param acquired from this documentation:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sagemaker-runtime.html#SageMakerRuntime.Client.invoke_endpoint

Sample subsegment from end-to-end test, works as expected:

{
    "id": "fc174e725fa660c3",
    "name": "SageMakerRuntime",
    "start_time": 1573676110.9078012,
    "end_time": 1573676110.98827,
    "http": {
        "response": {
            "status": 200
        }
    },
    "aws": {
        "endpoint_name": "test-endpoint-2",
        "operation": "InvokeEndpoint",
        "region": "us-east-1",
        "request_id": "16e2f384-dbf0-4ba7-b94a-7b70f511b476",
        "resource_names": [
            "test-endpoint-2"
        ]
    },
    "namespace": "aws"
}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #183 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage    83.4%   83.33%   -0.07%     
==========================================
  Files          77       77              
  Lines        2910     2910              
==========================================
- Hits         2427     2425       -2     
- Misses        483      485       +2
Impacted Files Coverage Δ
aws_xray_sdk/core/sampling/local/reservoir.py 88.88% <0%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d92820...d01da7f. Read the comment docs.

Copy link
Contributor

@bhautikpip bhautikpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@bhautikpip bhautikpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bhautikpip bhautikpip self-requested a review November 19, 2019 20:05
@bhautikpip bhautikpip merged commit 697f06a into aws:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants