-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issue-202] extension support as Bottle plugin #204
Conversation
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
+ Coverage 83.92% 84.21% +0.29%
==========================================
Files 77 78 +1
Lines 3004 3067 +63
==========================================
+ Hits 2521 2583 +62
- Misses 483 484 +1
Continue to review full report at Codecov.
|
reason for build fail: aio-libs/aiobotocore@01269ab#diff-ed4c34632c864bc20155bf0c714ee987L86 |
Yeah we already have a PR ready to fix this (#205). So once we merge it this should be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@bhautikpip is it Ok that I can't see my contribution here https://github.com/aws/aws-xray-sdk-python/graphs/contributors? |
Looks like I can see you in the contributor list. (scroll down a bit) |
it's previous small pull request, not this one |
Issue #, if available:
#202
Description of changes:
Added support for Bottle as a plugin
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.