Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-202] extension support as Bottle plugin #204

Merged
merged 4 commits into from
Mar 4, 2020

Conversation

polamayster
Copy link
Contributor

Issue #, if available:
#202
Description of changes:
Added support for Bottle as a plugin

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #204 into master will increase coverage by 0.29%.
The diff coverage is 96.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   83.92%   84.21%   +0.29%     
==========================================
  Files          77       78       +1     
  Lines        3004     3067      +63     
==========================================
+ Hits         2521     2583      +62     
- Misses        483      484       +1
Impacted Files Coverage Δ
aws_xray_sdk/ext/bottle/middleware.py 96.82% <96.82%> (ø)
aws_xray_sdk/core/models/entity.py 92.36% <0%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47f1e8...5086260. Read the comment docs.

aws_xray_sdk/ext/bottle/plugin.py Outdated Show resolved Hide resolved
aws_xray_sdk/ext/bottle/plugin.py Outdated Show resolved Hide resolved
tests/ext/bottle/test_bottle.py Show resolved Hide resolved
tests/ext/bottle/views/index.tpl Outdated Show resolved Hide resolved
aws_xray_sdk/ext/bottle/plugin.py Outdated Show resolved Hide resolved
@polamayster
Copy link
Contributor Author

polamayster commented Mar 3, 2020

@bhautikpip
Copy link
Contributor

Yeah we already have a PR ready to fix this (#205). So once we merge it this should be good.

@bhautikpip bhautikpip self-requested a review March 4, 2020 22:41
Copy link
Contributor

@bhautikpip bhautikpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bhautikpip bhautikpip merged commit a839d7f into aws:master Mar 4, 2020
@polamayster
Copy link
Contributor Author

polamayster commented Mar 5, 2020

@bhautikpip is it Ok that I can't see my contribution here https://github.com/aws/aws-xray-sdk-python/graphs/contributors?

@bhautikpip
Copy link
Contributor

Looks like I can see you in the contributor list. (scroll down a bit)

@polamayster
Copy link
Contributor Author

it's previous small pull request, not this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants