Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using instance doc to fetch EC2 metadata. Added 2 additional fields #227

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

srprash
Copy link
Contributor

@srprash srprash commented May 31, 2020

Issue #, if available:

Description of changes:
Using EC2 instance document to fetch metadata all at once instead of separate request to different endpoints. This provides extensibility to add more metadata to the plugin.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2020

Codecov Report

Merging #227 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   79.22%   79.35%   +0.12%     
==========================================
  Files          80       80              
  Lines        3148     3158      +10     
==========================================
+ Hits         2494     2506      +12     
+ Misses        654      652       -2     
Impacted Files Coverage Δ
aws_xray_sdk/core/plugins/ec2_plugin.py 95.45% <100.00%> (+1.33%) ⬆️
aws_xray_sdk/core/sampling/local/reservoir.py 100.00% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe7f856...f7879b3. Read the comment docs.

@srprash srprash merged commit 7329636 into aws:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants