Add distribution channel smoke test #276
Conversation
| python-version: '3.x' | ||
| - run: pip install tox | ||
| - name: Run smoke tests | ||
| run: tox -c tox-distributioncheck.ini |
There was a problem hiding this comment.
How do we get notified if the workflow fails? Whom does GH sends notification to in case of a cron job?
There was a problem hiding this comment.
I've sent a few similar PRs, but they're just establishing the build, notification is the next step. I think notification will be literally copy paste of the exact same code for all repos so can follow up with it.
There was a problem hiding this comment.
I think we can probably add like binary metric (PythonSDKDistributionAvailabilityFailure) which publishes value based on Run smoke tests is passed or not and then we can set alarms on that for notifications. I think that would be a good notification model. I agree with @anuraaga notifications can be next step.
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
==========================================
- Coverage 79.58% 79.52% -0.07%
==========================================
Files 83 83
Lines 3277 3277
==========================================
- Hits 2608 2606 -2
- Misses 669 671 +2
Continue to review full report at Codecov.
|
Issue #, if available:
Description of changes:
Just builds without publishing any metrics for now
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.