Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exception when sending entity to Daemon #292

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Handle exception when sending entity to Daemon #292

merged 3 commits into from
Apr 27, 2021

Conversation

lupengamzn
Copy link
Contributor

Issue #, if available:

#288

Description of changes:

  • Discard sending entity to Daemon if any exception happens during serialization

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2021

Codecov Report

Merging #292 (8fc364a) into master (e7711fe) will increase coverage by 0.10%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
+ Coverage   79.53%   79.63%   +0.10%     
==========================================
  Files          83       83              
  Lines        3279     3276       -3     
==========================================
+ Hits         2608     2609       +1     
+ Misses        671      667       -4     
Impacted Files Coverage Δ
aws_xray_sdk/core/emitters/udp_emitter.py 63.15% <0.00%> (ø)
aws_xray_sdk/core/models/entity.py 94.11% <100.00%> (+1.16%) ⬆️
aws_xray_sdk/core/sampling/local/reservoir.py 100.00% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7711fe...8fc364a. Read the comment docs.

@lupengamzn lupengamzn merged commit 48b2d08 into aws:master Apr 27, 2021
Hargrav3s pushed a commit to Gavant/aws-xray-sdk-python that referenced this pull request Mar 22, 2022
* Handle exception when sending entity to Daemon

* Added full stop

* Removed try-catch block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants