Fix TypeError by patching register_default_jsonb from psycopg2 #350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #243
Description of changes:
As mentioned in the above issue, this change in Django's newer version calls
psycopg2.extras.register_default_jsonb
which in turn callsregister_type
but our existing patch fails to unwrap the connection to expected type. Therefore resulting inTypeError: argument 2 must be a connection, cursor or None
.This PR adds a patch for
register_default_jsonb
so that we unwrap the connection or cursor object (if it's wrapped) and pass it onto the wrapped function.Testing:
The unit test case
test_register_default_jsonb
fails (as expected) when run without the fix but passes with the fix:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.