Fix http.URL field segment for Aiohttp extension #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haotianw465
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation sends an invalid payload for the URL segment field once is serialized. The following snippet shows the output that is sent:
{"end_time": 1520921976.0243928, "http": {"request": {"client_ip": "127.0.0.1", "method": "GET", "url": [["http", "localhost:5000", "/operations/healthcheck", "", ""]], "user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.186 Safari/537.36"}, "response": {"status": 200}}, "id": "713f9e1ef69bce80", "in_progress": false, "name": "test", "start_time": 1520921976.023138, "trace_id": "1-5aa76d78-99ea86b4976213b1548fb9ae"} to xray:2000.The serializer tries to serialize the URL object that is not a string is basically a YARL object, so having as an output this weird
[["http", "localhost:5000", "/operations/healthcheck", "", ""]]value that is not well interpreted by the AWS Console.The fix basically castes the field to a string and test properly this casting, having an alignment with other implementations such as the Flask one.