Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests against Python 3.10 and 3.11 #376

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Conversation

michael-k
Copy link
Contributor

Issue #, if available: n/a

Description of changes: Run tests against Python 3.10 and 3.11. Also add trove classifiers.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@michael-k michael-k requested a review from a team as a code owner January 17, 2023 12:19
@michael-k
Copy link
Contributor Author

The one failing test is unrelated.

I did however not expect for the tests to pass because the packages used to provide PostgreSQL and MySQL aren't compatible with Python 3.1x. But at least the ones used for MySQL have to be replaced by others anyway when moving away from Ubuntu 18.04 (which is deprecated by GitHub Actions). But that's out of scope for this PR.

@srprash
Copy link
Contributor

srprash commented Jan 30, 2023

Looking at the latest CI run, seems like we'll have to fix the sqlalchemy tests (SQLalchemy 2.0 release broke some functionality) before we can add python 3.1x versions to it.
We will be working on fixing the CI shortly.

@srprash
Copy link
Contributor

srprash commented Feb 13, 2023

I will go ahead and approve this PR since the test failures are unrelated to this change. I will create another PR in the meantime to pin the sqlalchemy to 1.x.
Thanks!

@willarmiros willarmiros merged commit 6a4c9ee into aws:master Feb 13, 2023
@michael-k michael-k deleted the python3.1x branch February 21, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants