-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give up when there is no open segment and LOG_ERROR is configured #58
Give up when there is no open segment and LOG_ERROR is configured #58
Conversation
Without setting this flag as False, any HTTP call done with the Aiohttp Client when there is no an active segment will fail with the SegmentNotFoundException exception. This issue can be annoying for this systems that do not create explicitly the segements and relay on the sampled incomming requests, which create automatically segments just for a sub set of the incomming request.
Please consider this as a potential bug that might require a minor release. |
Closing, the segment is always created by the middleware ... If I've found something different I will reopen it. Sorry for the noise |
Reopening, worth considering the option of giving the option to the user to not break the request if any segment is present. |
Hi, did you check If the aiohttp client errors out due to segment is |
You are right. In any case, PR fixed to take into account that Aiohttp client tracing must give up silently when the So, yes it needs to be fixed yet. |
raise_if_not_subsegment
for Aiohttp client
Any chance to have a minor release? |
Yes we will get a minor release as soon as possible. Thanks for your patience. |
@haotianw465 please consider this PR #59 also as a bug, therefore a candidate for the minor release. |
Without setting this flag as False, any HTTP call done with the Aiohttp
Client when there is no an active segment will fail with the
SegmentNotFoundException exception.
This issue can be annoying for this systems that do not create
explicitly the segements and relay on the sampled incomming requests,
which create automatically segments just for a sub set of the incomming
request.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.