ISSUE-80: Add patch support for psycopg2 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tankanow
commented
Aug 29, 2018
aws_xray_sdk/ext/psycopg2/patch.py
Outdated
|
|
||
| conn = wrapped(*args, **kwargs) | ||
| meta = { | ||
| 'database_type': 'postgresql', |
There was a problem hiding this comment.
@haotianw465, how do I see the custom metadata in XRay? I system tested this code by deploying it along with one of my Lambda functions; I did see the correct database_type, however I did not see database_host, database_name, or database_user in the Raw Trace Data in the AWS XRay Console.
There was a problem hiding this comment.
The service will drop unknown keys. Here is a sample sql document the service support.
"sql" : {
"url": "jdbc:postgresql://aawijb5u25wdoy.cpamxznpdoq8.us-west-2.rds.amazonaws.com:5432/ebdb",
"preparation": "statement",
"database_type": "PostgreSQL",
"database_version": "9.5.4",
"driver_version": "PostgreSQL 9.4.1211.jre7",
"user" : "dbuser"
}
…an compare versions
|
@haotianw465, I updated the metadata and confirmed via system test that it shows up in the AWS XRay Console. Please let me know if there is anything else I should do for this PR. |
haotianw465
approved these changes
Aug 31, 2018
|
Thank you for your contribution. I have merged your PR and will roll it out in our next release. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 80
Add patch support for psycopg2 using existing
dbapi2tracing classes. For now, addhost,database,user, anddatabase_typetosqlmetadata.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.