Support dbname and database kwarg in psycopg2.connect() #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #90
*Description of changes:
psycopg2.connect() Supports 3 variants of operation:psycopg2.connect("dbname=test user=postgres password=secret")psycopg2.connect(dbname="test", user="postgres", password="secret")psycopg2.connect()Previously we only supported 1 and 2. Now support variant 3 and mix of 2 and 3.This change is not entierly backwards compatible previously the metadata used tocontain keys
url
anduser
. These are no longer exposed however the connectionparameters are available as
connection_string
. If this backward incompatibilityis not desirable then change can be made to extract values as they were before
using conn.dsn. However the URL will not be correct as password is mangled. It's
not clear to me if one option is clearly better than the other.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.