chore(cli): add task delete validate/ask #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(aws): add ListStacksWithTags method chore(aws): remove unused client call from interfaces chore(cloudformation): add ListStacksWIthTags to cf interfaces chore(cloudformation): extract task stack name pattern to variable in deploy pkg chore(awscfn): fix staticcheck error chore(cloudformation): address feedback chore(cloudformation): revert invalid change to ListDefaultTaskStacks chore(cloudformation): regenerate mocks chore(cloudformation): remove unnecessary private method
huanjani
reviewed
Jan 15, 2021
| // Validate checks that flag inputs are valid. | ||
| func (o *deleteTaskOpts) Validate() error { | ||
|
|
||
| if o.name != "" { |
There was a problem hiding this comment.
I'm probably missing it-- do we validate that the flag-inputted task exists?
There was a problem hiding this comment.
No. It's difficult because in the case where a task is provided but no app, env, or default cluster flag, we don't know where to look for the task.
In these cases we rely on error messages returned when we go looking for the task or service in the Execute logic.
iamhopaul123
approved these changes
Jan 16, 2021
internal/pkg/cli/task_delete.go
Outdated
| deleteTaskVars: vars, | ||
|
|
||
| store: store, | ||
| // spinner: termprogress.NewSpinner(log.DiagnosticWriter), |
There was a problem hiding this comment.
Oh maybe this one as well.
iamhopaul123
added
the
do-not-merge
bvtujo
removed
the
do-not-merge
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
<!-- Provide summary of changes --> Adds the skeleton of a new `task delete` command with Ask() and Validate() filled in. Tests for Ask() forthcoming, then I'll work on Execute in a separate PR. <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the skeleton of a new
task deletecommand with Ask() and Validate() filled in. Tests for Ask() forthcoming, then I'll work on Execute in a separate PR.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.