Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme file to include domainless gMSA pathway explanation within prerequisites #127

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

SovietFrontier
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:
Update readme file to include domainless gMSA pathway explanation within prerequisites. In order to use credential fetcher with Amazon Elastic Container Service (Amazon ECS), you must use domainless gMSA as described in the documentation. Looking between that documentation and the information listed in the prerequisites here, it is conflicting. This update will add the caveat for using Amazon ECS - Fargate.

Testing done:
N/A

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have updated any necessary documentation, including READMEs and comments (where appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific environment
  • No tests as this is a documentation change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Beau-Gosse-dev
Copy link
Contributor

Hi! Thanks for finding and fixing this issue! We'll get this reviewed and merged soon.

README.md Outdated Show resolved Hide resolved
documentation: updating the explanation for Linux Fargate domainless gMSA

Co-authored-by: Anushka Srinivasa <as14692@nyu.edu>
@smhmhmd smhmhmd merged commit 81084ba into aws:mainline Jun 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants