Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Conditionally use dotnet-runtime-8/dotnet-sdk-8 on Fedora 41 #130

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

as14692
Copy link
Contributor

@as14692 as14692 commented Jul 8, 2024

Description of changes:

  • https://bugzilla.redhat.com/show_bug.cgi?id=2294017
  • Currently credentials-fetcher requires dotnet-runtime-6 and dotnet-sdk-6
  • Fedora 41 fails to install credentials-fetcher because Fedora41 does not have .NET6 support
  • To support Fedora41, use dotnet-runtime-8 and dotnet-sdk-8 if the OS is Fedora 41 or later

Testing done:

Successfully built the rpm on Fedora 41 docker container, Fedora-Cloud-Base-AmazonEC2.x86_64-40 ami and al2023 ami

Merge Checklist

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have updated any necessary documentation, including READMEs and comments (where appropriate)

Tests

  • [NA ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific environment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@as14692 as14692 requested review from smhmhmd and jamolina July 8, 2024 23:01
Copy link
Contributor

@jamolina jamolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One question, were you going to update the patch version on package/credentials-fetcher.spec as well?

@as14692
Copy link
Contributor Author

as14692 commented Jul 8, 2024

Looks good. One question, were you going to update the patch version on package/credentials-fetcher.spec as well?

Discussed offline. Will change in a release PR.

@as14692 as14692 requested a review from jamolina July 8, 2024 23:34
Copy link
Contributor

@jamolina jamolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @as14692 !

@as14692 as14692 merged commit 4cd83a0 into mainline Jul 8, 2024
1 check passed
@as14692 as14692 deleted the bugfix-fedora41-support branch October 15, 2024 22:43
@bhallasaksham bhallasaksham mentioned this pull request Jan 15, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants