Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query SRV records #135

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Query SRV records #135

merged 2 commits into from
Sep 5, 2024

Conversation

smhmhmd
Copy link
Contributor

@smhmhmd smhmhmd commented Sep 5, 2024

Issue #, if available:
Use SRV records to query for Microsoft Active Directory as per https://learn.microsoft.com/en-us/troubleshoot/windows-server/networking/verify-srv-dns-records-have-been-created#method-3-use-nslookup
Description of changes:

See these in the logs:
Found ldap._tcp.dc._msdcs DNS controller ip-aaaaa.contoso.com
Found ldap._tcp.dc._msdcs DNS controller ip-bbbbb.contoso.com

Testing done:
Tested domain-joined and domainless (opensource mode)

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have updated any necessary documentation, including READMEs and comments (where appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific environment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

See these in the logs:
Found ldap._tcp.dc._msdcs DNS controller ip-aaaaa.contoso.com
Found ldap._tcp.dc._msdcs DNS controller ip-bbbbb.contoso.com
@smhmhmd smhmhmd merged commit 0901c03 into aws:mainline Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants