-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade utf_16 project to use .NET 8 with NativeAot and remove runtime .NET dependency #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smhmhmd
reviewed
Dec 15, 2024
smhmhmd
reviewed
Dec 15, 2024
smhmhmd
reviewed
Dec 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the change, this would remove the runtime dependency on dotnet.
2 changes as discussed:
- Add Readme in the setup_scripts directory since there is similar logic in the docker dir as well.
- Remove build-using-csc.sh and Program.runtimeconfig.json
smhmhmd
approved these changes
Jan 2, 2025
as14692
approved these changes
Jan 2, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Upgrade utf_16 code to dotnet8 with NativeAot. This will remove the runtime dependency for dotnet.
Testing done:
Created a new rpm (v1.3.65) and updated the rpm in ecs ec2 instance and linux ec2 instance. Verified that new tickets are being created in all modes.
Pending testing for renewals in Linux (AL2023) and ECS non domain-joined mode.
1.3.65 rpm size: 2.5MB
1.3.6 rpm size: 1.9MB
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.