Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade utf_16 project to use .NET 8 with NativeAot and remove runtime .NET dependency #151

Merged
merged 13 commits into from
Jan 2, 2025

Conversation

bhallasaksham
Copy link
Contributor

@bhallasaksham bhallasaksham commented Dec 14, 2024

Description of changes:

Upgrade utf_16 code to dotnet8 with NativeAot. This will remove the runtime dependency for dotnet.

Testing done:

  • Tested on Ubuntu Open Source Mode
  • Tested on Linux AL2023 Open Source Mode
  • Tested on ECS non domain-joined mode

Created a new rpm (v1.3.65) and updated the rpm in ecs ec2 instance and linux ec2 instance. Verified that new tickets are being created in all modes.

Pending testing for renewals in Linux (AL2023) and ECS non domain-joined mode.

1.3.65 rpm size: 2.5MB
1.3.6 rpm size: 1.9MB

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have updated any necessary documentation, including READMEs and comments (where appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific environment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bhallasaksham bhallasaksham requested review from as14692 and smhmhmd and removed request for as14692 December 14, 2024 01:03
@bhallasaksham bhallasaksham marked this pull request as draft December 14, 2024 01:16
@bhallasaksham bhallasaksham marked this pull request as ready for review December 14, 2024 22:12
@bhallasaksham bhallasaksham changed the base branch from fixes_for_DNS_and_distinguishedName to dev December 17, 2024 22:45
@bhallasaksham bhallasaksham changed the title dotnet upgrade Upgrade utf_16 project to use .NET 8 with NativeAot and remove runtime .NET dependency Dec 31, 2024
Copy link
Contributor

@smhmhmd smhmhmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change, this would remove the runtime dependency on dotnet.
2 changes as discussed:

  1. Add Readme in the setup_scripts directory since there is similar logic in the docker dir as well.
  2. Remove build-using-csc.sh and Program.runtimeconfig.json

@bhallasaksham bhallasaksham requested a review from smhmhmd January 2, 2025 18:30
@bhallasaksham bhallasaksham merged commit d793d22 into aws:dev Jan 2, 2025
@bhallasaksham bhallasaksham mentioned this pull request Jan 15, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants