Add rpm-without-system-rust to rpmspec #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the rpmspec with the following conditions - with system_rust - without system_rust [1] is the default and builds the rpmspec with rustc and cargo provided they are installed with yum [2] builds the rpmspecfile with rustc and cargo installed outside of yum (in cases where rustup was used to install both rustc and cargo) [1] and [2] makes it possible to build both instances using the Makefile. The old makefile command make rpm stays the same but assumes [1] and the new command make rpm-without-system-rust assumes [2]
|
/lgtm |
|
@mskanth972 is there anything I can do to help get this merged? |
|
I bought this up internal, we are planning to revert the change which was made in efs-utils previously as its creating a blockage for ADC regions(isolated regions) regarding the rust installation, will update you by end of the week on this. |
|
@mskanth972 hope all is well. Can we get some movement on this PR as it is blocking kubernetes-sigs/aws-efs-csi-driver#1440 Thanks and have a good weekend |
anthotse
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the rpmspec with the following conditions
[1] is the default and builds the rpmspec with
rustc and cargo provided they are installed
with yum
[2] builds the rpmspecfile with rustc and cargo
installed outside of yum (in cases where rustup
was used to install both rustc and cargo)
[1] and [2] makes it possible to build both
instances using the Makefile.
The old makefile command
stays the same but assumes [1] and the new
command
assumes [2]
Issue #, if available:
kubernetes-sigs/aws-efs-csi-driver#1440
Description of changes:
The build in https://github.com/kubernetes-sigs/aws-efs-csi-driver fails because they use an image which installs rust using rustup. Adding
make rpm-without-system-rustwill allow for such instances when there is the need to buildwith rust not installed by yum.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.