-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump image-builder to v0.1.16 #2264
Conversation
- update patches - delete patch 0016 because already in upsteam: kubernetes-sigs/image-builder@2a4bdfb?diff=unified
Hi @adiantum. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for the contribution!
I started this work in the context of adding support for ubuntu 22.04 in my PR here. Im happy to approve and merge this one tho so we can get it in sooner.
The one thing I changed in my attempt was the two patches where we add a few vars to the ansible list. This patch always conflicts and requires us to update it. I was thinking we could move the 3 or 4 additional vars we add to the end of the list instead of in the middle where they are now to try and avoid the diff everytime. Any thoughts on this? Would you mind updating yours to do the same, or feel free to push back.
I think that's great idea! I believe it should help to maintain there patches in future. I'll update the PR based on your work. |
@jaxesn I made the changes in ansible vars patches. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaxesn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/unhold |
Description of changes:
Nutanix image tested successfully.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.