-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump CAPI and cert-manager versions #2269
Bump CAPI and cert-manager versions #2269
Conversation
8500f0c
to
c413fd8
Compare
c413fd8
to
bce6e4d
Compare
bce6e4d
to
d68bbc7
Compare
d68bbc7
to
9f32483
Compare
/override eks-anywhere-cli-tools-tooling-presubmit |
@abhay-krishna: Overrode contexts on behalf of abhay-krishna: eks-anywhere-cli-tools-tooling-presubmit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -25,8 +25,8 @@ BINARY_PLATFORMS="$5" | |||
TAR_PATH="$6" | |||
GIT_HASH="$7" | |||
|
|||
LICENSES_PATH="$OUTPUT_DIR/LICENSES" | |||
ATTRIBUTION_PATH="$OUTPUT_DIR/ATTRIBUTION.txt" | |||
LICENSES_PATHS=($(find $OUTPUT_DIR -type d -name "LICENSES")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh dang im surprised this wasnt already handled. i guess we just didnt notice for projects with multiple attr files they werent getting put in the tarball? or maybe this is the first one that produces a tarball and multiple attr files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes even i was surprised. There are others like the tinkerbell actions that produce multiple attribution files but we don't have tarball for those
/override kind-tooling-presubmit |
@abhay-krishna: Overrode contexts on behalf of abhay-krishna: kind-tooling-presubmit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bumping versions for CAPI and cert-manager.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.