Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CAPI and cert-manager versions #2269

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

abhay-krishna
Copy link
Member

Bumping versions for CAPI and cert-manager.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added do-not-merge/work-in-progress size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 27, 2023
@abhay-krishna abhay-krishna force-pushed the bump-capi-cert-manager branch 2 times, most recently from 8500f0c to c413fd8 Compare June 28, 2023 01:40
@abhay-krishna abhay-krishna changed the title WIP: Bump CAPI and cert-manager versions Bump CAPI and cert-manager versions Jun 28, 2023
@abhay-krishna
Copy link
Member Author

/override eks-anywhere-cli-tools-tooling-presubmit
expected failure

@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: Overrode contexts on behalf of abhay-krishna: eks-anywhere-cli-tools-tooling-presubmit

In response to this:

/override eks-anywhere-cli-tools-tooling-presubmit
expected failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@g-gaston g-gaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@@ -25,8 +25,8 @@ BINARY_PLATFORMS="$5"
TAR_PATH="$6"
GIT_HASH="$7"

LICENSES_PATH="$OUTPUT_DIR/LICENSES"
ATTRIBUTION_PATH="$OUTPUT_DIR/ATTRIBUTION.txt"
LICENSES_PATHS=($(find $OUTPUT_DIR -type d -name "LICENSES"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh dang im surprised this wasnt already handled. i guess we just didnt notice for projects with multiple attr files they werent getting put in the tarball? or maybe this is the first one that produces a tarball and multiple attr files?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes even i was surprised. There are others like the tinkerbell actions that produce multiple attribution files but we don't have tarball for those

@abhay-krishna
Copy link
Member Author

/override kind-tooling-presubmit
This issue won't be seen in Codebuild

@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: Overrode contexts on behalf of abhay-krishna: kind-tooling-presubmit

In response to this:

/override kind-tooling-presubmit
This issue won't be seen in Codebuild

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhay-krishna
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 22f036c into aws:main Jun 28, 2023
@abhay-krishna abhay-krishna deleted the bump-capi-cert-manager branch June 28, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants