Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes staging buildspec generation to account of release branched deps #2298

Merged
merged 1 commit into from
Jul 6, 2023
Merged

fixes staging buildspec generation to account of release branched deps #2298

merged 1 commit into from
Jul 6, 2023

Conversation

jaxesn
Copy link
Member

@jaxesn jaxesn commented Jul 6, 2023

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 6, 2023
abhinavmpandey08
abhinavmpandey08 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@abhinavmpandey08 abhinavmpandey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/woof

@eks-distro-bot
Copy link
Collaborator

@abhinavmpandey08: dog image

In response to this:

/approve
/lgtm
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaxesn jaxesn merged commit 4bdbeda into aws:main Jul 6, 2023
1 check passed
@jaxesn
Copy link
Member Author

jaxesn commented Jul 6, 2023

/cherrypick release-0.16

@eks-distro-pr-bot
Copy link
Contributor

@jaxesn: new pull request created: #2299

In response to this:

/cherrypick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-pr-bot eks-distro-pr-bot mentioned this pull request Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavmpandey08 abhinavmpandey08 abhinavmpandey08 approved these changes

Assignees

@abhinavmpandey08 abhinavmpandey08

Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jaxesn @eks-distro-bot @eks-distro-pr-bot @abhinavmpandey08