disables udp offload on redhat for vwmare #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/M
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaxesn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -1,7 +1,7 @@ | |||
| From eb0ec6499bcf05e4683215c6bbcee1a74cbecdcc Mon Sep 17 00:00:00 2001 | |||
| From: Vignesh Goutham Ganesh <vgg@amazon.com> | |||
| Date: Fri, 2 Sep 2022 14:32:21 -0700 | |||
| Subject: [PATCH 08/17] Support crictl validation from input checksum | |||
There was a problem hiding this comment.
This should be 7, and the numbers from 7 to 13 need to be fixed.
abhay-krishna
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
When updating to cilium 1.12 we ran into the udp offload issue on vmware with Redhat 8. We have seen this problem off an on, seems to depend on the specific version of vpshere, with BR for a while due to their use are pretty new kernels. Recently they implemented a solution by disabling udp offloading. There is also potentially some official guidance coming from the cilium community on this issue for vmware environments.
This patches our build of image builder to add a similar systemd unit to the Redhat build for vmware. @taneyland has tested this manually.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.