Add a CAPI patch to allow registry mirror configuration to be mutable #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/L
cxbrowne1207
force-pushed
the
patch-capi-allow-registry-mirror-config-mutable
branch
2 times, most recently
from
b90b376
to
84c84c8
Compare
|
/test cluster-api-tooling-presubmit |
cxbrowne1207
force-pushed
the
patch-capi-allow-registry-mirror-config-mutable
branch
from
bf8f36a
to
84c84c8
Compare
cxbrowne1207
force-pushed
the
patch-capi-allow-registry-mirror-config-mutable
branch
from
84c84c8
to
8991036
Compare
|
/test cluster-api-tooling-presubmit |
cxbrowne1207
force-pushed
the
patch-capi-allow-registry-mirror-config-mutable
branch
from
335cbb5
to
2ad64ec
Compare
cxbrowne1207
changed the title
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: cxbrowne1207 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1526
Description of changes:
Currently, the registry mirror configuration is an immutable field on CAPI side, which blocks it from being upgraded when using BR. Users may need to upgrade this field due to expired certs or other changes. This patch allows registry mirror configurations to be mutable
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.