Update capi etcd patch to avoid NodeHealthy false #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/L
jiayiwang7
reviewed
Jul 27, 2023
projects/kubernetes-sigs/cluster-api/patches/0001-Adding-capi-support-for-Bottlerocket.patch
Show resolved
Hide resolved
g-gaston
force-pushed
the
fix-nodehealthy-condition-for-etcd-machines-patch
branch
from
8ed9359
to
21fa821
Compare
|
/retest |
|
/lgtm |
g-gaston
force-pushed
the
fix-nodehealthy-condition-for-etcd-machines-patch
branch
from
21fa821
to
59173f7
Compare
|
/test cluster-api-tooling-presubmit |
g-gaston
force-pushed
the
fix-nodehealthy-condition-for-etcd-machines-patch
branch
2 times, most recently
from
d2769f9
to
de819ed
Compare
g-gaston
force-pushed
the
fix-nodehealthy-condition-for-etcd-machines-patch
branch
from
de819ed
to
35c8170
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: g-gaston The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes aws/eks-anywhere#5893
Description of changes:
For an easier review: abhay-krishna/cluster-api@99a91f2
There is no impact in the execution flow. It's mostly to avoid confusion when looking at the machine status.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.