✨ Add CAPI patch to support in-place upgrade in KCP #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
do-not-merge/hold
size/L
abhinavmpandey08
changed the title
abhinavmpandey08
changed the title
abhinavmpandey08
force-pushed
the
capi-in-place
branch
3 times, most recently
from
0ebce31
to
3c7c721
Compare
|
/unhold |
abhinavmpandey08
force-pushed
the
capi-in-place
branch
from
3c7c721
to
3f8910c
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavmpandey08 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds support for InPlace upgrade strategy in KCP. When the deployment strategy is set to InPlace, the kubeadm-control-plane-controller adds a controlplane.clusters.x-k8s.io/in-place-upgrade-needed annotation to the KCP object when an upgrade is needed. The external upgrader should watch for this annotation and trigger an in-place upgrade when it's added.
After the upgrade is done, the external upgrader is expected to update the statuses and remove this annotation.
Corresponding PR on our CAPI fork abhay-krishna/cluster-api#27
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.