Handle race condition when upgrading capi CRDs #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/L
g-gaston
force-pushed
the
capi-1.6.0-patch-crd-race-condition
branch
2 times, most recently
from
de8a503
to
dfff637
Compare
g-gaston
force-pushed
the
capi-1.6.0-patch-crd-race-condition
branch
from
dfff637
to
5ecd7df
Compare
taneyland
approved these changes
Jan 23, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: g-gaston The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
/test all |
|
/test cluster-api-tooling-presubmit |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
More info about the issue and the root cause: kubernetes-sigs/cluster-api#10032
This patch just detects when this error happens and sends an interrupt signal to the process. This should trigger a "graceful shutdown" in programs using controller-runtime. That should "wait" for ongoing requests to finish and stop the program. This way, the container gets restarted and the problematic cache gets cleaned up.
It's possible I might change this patch to something different after talking to capi folks, but at least this fixes the issue in the short term so we can get the tests rolling.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.