-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add capi patch to enable kubeadm feature flags mutation #2958
Conversation
/lgtm |
bdcf160
to
2e38d58
Compare
projects/kubernetes-sigs/cluster-api/patches/0041-enable-kubeadm-feature-flags-mutation.patch
Outdated
Show resolved
Hide resolved
2e38d58
to
d49397f
Compare
d49397f
to
c46ebe1
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavmpandey08 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick main |
@abhinavmpandey08: #2958 failed to apply on top of branch "main":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick main |
@abhinavmpandey08: new pull request created: #2966 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes:
Currently, kubeadm feature flags are immutable which cause issues when upgrading a cluster from 1.28 to 1.29 as we try to disable the
EtcdLearnerMode
feature flag. This gets blocked by webhooks because the feature flag itself is immutable.This PR patches CAPI based on this upstream PR kubernetes-sigs/cluster-api#10154 to make this field mutable.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.