-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patch for insecure proxy support for helm #3046
Conversation
b33423e
to
2e1639d
Compare
2e1639d
to
6d4a0b3
Compare
6d4a0b3
to
c116fdd
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahreehong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.19 |
@ahreehong: #3046 failed to apply on top of branch "release-0.19":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
Description of changes:
We removed our patches adding support for the flag --insecure-skip-tls-verify, as the functionality had been added to upstream helm. However, upstream has a bug when using proxy with the --insecure-skip-tls-verify flag so the helm commands fails.
This PR adds a patch to fix this bug
Testing
Manually ran helm commands with the
--insecure-skip-tls-verify
flag with proxy and verified the commands work.Built EKS-A controller to use the patched helm and verified cluster creation worked.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.