Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cert-manager to 1.14.2 #3063

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

tatlat
Copy link
Member

@tatlat tatlat commented Apr 8, 2024

This PR bumps cert-manager/cert-manager to v1.14.2, along with other updates such as Go version, checksums and attribution files.

Compare changes
Release notes

/hold
/area dependencies

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added area/dependencies do-not-merge/hold size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 8, 2024
@tatlat
Copy link
Member Author

tatlat commented Apr 11, 2024

/unhold

@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 4b24ee6 into aws:main Apr 12, 2024
2 of 3 checks passed
- repository: quay.io/jetstack/cert-manager-ctl
# The container image for the cert-manager startupapicheck
# +docs:property
- repository: quay.io/jetstack/cert-manager-startupapicheck
+ repository: cert-manager/cert-manager-ctl
Copy link
Member

@sp1999 sp1999 Sep 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using cert-manager-ctl repository for cert-manager-startupapicheck?

From the v1.14.0 changelog,

🔧 Breaking Changes
The startupapicheck job uses a new OCI image called "startupapicheck", instead of the ctl image.
If you run in an environment in which images cannot be pulled, be sure to include the new image.

https://github.com/cert-manager/cert-manager/pull/6549/files#diff-719152aa560e98613908347a8a4426abb52974938a36e334d066bf084daf1716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependencies lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants