-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1-30 release branch support #3071
Add 1-30 release branch support #3071
Conversation
Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
Signed-off-by: EC2 Default User <ec2-user@ip-172-31-27-205.us-west-2.compute.internal>
Signed-off-by: Rahul Ganesh <rahulbabu95@gmail.com>
Signed-off-by: Rahul Ganesh <rahulbabu95@gmail.com>
/test autoscaler-1-30-presubmit |
/test cloud-provider-vsphere-1-30-tooling-presubmit |
/test imagebuilder-1-30-presubmit |
Signed-off-by: Rahul Ganesh <rahulbabu95@gmail.com>
Signed-off-by: Rahul Ganesh <rahulbabu95@gmail.com>
@@ -68,6 +68,7 @@ ADDITIONAL_PAUSE_1-26_FROM=1-26 | |||
ADDITIONAL_PAUSE_1-27_FROM=1-27 | |||
ADDITIONAL_PAUSE_1-28_FROM=1-28 | |||
ADDITIONAL_PAUSE_1-29_FROM=1-28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason we're still using 1-28 for 1-29 and 1-30?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the pauseVersion between 1-28, 1-29 and 1-30 didn't change from 3.9 in Kubernetes. This can be verified by checking the value for different branches 1-28, 1-29 & 1-30. Basically we can use the same value as of 1-28!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good explanation!
@@ -47,6 +47,12 @@ batch: | |||
compute-type: BUILD_GENERAL1_SMALL | |||
variables: | |||
RELEASE_BRANCH: 1-29 | |||
- identifier: aws_bottlerocket_bootstrap_1_30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is adding these a problem if a 1.30 BR release doesnt exist yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to track it in the code, if we need it and checked with @abhay-krishna too. Looks like this is an independent project and there's no dependency with BR release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable to me. Not sure about the BR builds, i feel like we usually have to wait on those?
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rahulbabu95 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
Add EKS-D 1-30 release branch support for build-tooling projects.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.