Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tink to v0.10.0 #3087

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Bump tink to v0.10.0 #3087

merged 1 commit into from
Apr 17, 2024

Conversation

ahreehong
Copy link
Member

@ahreehong ahreehong commented Apr 16, 2024

Issue #, if available:

Description of changes:
Bump tink version from v0.8.0 to v0.10.0

Removes --tls=false from the tink-server deployment as the flag is removed upstream

We need the patch due to same issue explained here: https://github.com/aws/eks-anywhere-build-tooling/pull/754/files#r865110369. Since we are removing .ONESHELL, we need to fix the whitespace for the out/release/tink.yaml target

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 16, 2024
Copy link
Member

@abhay-krishna abhay-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 877ced5 into aws:main Apr 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants