Bump capi to v1.8.3 #3805
Merged
Bump capi to v1.8.3 #3805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
eks-distro-bot
added
do-not-merge/hold
size/XXL
sp1999
force-pushed
the
bump-capi-to-v1.8.3
branch
from
e0916c6 to
6b52271
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sp1999 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sp1999
force-pushed
the
bump-capi-to-v1.8.3
branch
from
6b52271 to
da81cb4
Compare
tatlat
requested changes
Sep 30, 2024
...bernetes-sigs/cluster-api/patches/0041-Update-generated-files-by-running-make-generate.patch
Outdated
Show resolved
Hide resolved
sp1999
force-pushed
the
bump-capi-to-v1.8.3
branch
from
da81cb4 to
2574981
Compare
sp1999
force-pushed
the
bump-capi-to-v1.8.3
branch
from
2574981 to
39340e4
Compare
|
/lgtm |
|
/unhold |
tatlat
approved these changes
Sep 30, 2024
rahulbabu95
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Don't think we need this patch anymore. corefile-migration v1.0.23 supports coredns version 1.11.3 that eks-d currently ships.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR bumps CAPI to the latest v1.8.3 to support Kubernetes 1.31.
Notable changes in CAPI v1.8.0:
CABPK: Add kubeadm v1beta4 types (including ExtraEnvs and ImagePullSerial)
PR: kubernetes-sigs/cluster-api#10709 and kubernetes-sigs/cluster-api#10846
Dependency: Bump controller-runtime to v0.18.0
PR: kubernetes-sigs/cluster-api#10383
Notable changes in controller-runtime v0.18.0
Source, Event, Predicate, Handler: Add generics support
PR: kubernetes-sigs/controller-runtime#2783 and kubernetes-sigs/controller-runtime#2796
Note:
Always run
make generatein the upstream CAPI patched repo to make sure all the generated crds, deepcopy files, rbac objects and webhook configuration objects are up-to-date using controller-gen CLI and the conversion files are up-to-date using conversion-gen CLI. We ran into an issue this time where the crds weren't up-to-date with the latest patch updates and the cluster creation was failing to install etcdadmcluster with the following error message in the API server:Testing
Ran
TestVSphereKubernetes131Ubuntu2004SimpleFlowandTestVSphereKubernetes131BottlerocketLabelsUpgradeFlowE2E tests locally using bundles-override with the latest dev bundle having the new cluster-api v1.8.3 manifests. The tests passed successfully.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.