Update install workflow to support Go v1.18 #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command 'go get' can no longer be used to build packages starting Go v1.18 (https://go.dev/doc/go-get-install-deprecation). Kustomize version also needs to be updated to v4.5 since go install doesn't support exclude directives (kubernetes-sigs/kustomize#3618). The change has been tested on both Go v1.17 and Go v1.18 to ensure the Makefile works properly.
eks-distro-bot
added
approved
size/XS
|
/hold |
We spoke some at standup, and I've verified with @ivyostosh that all uses of /unhold |
ewollesen
approved these changes
Apr 27, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ewollesen, ivyostosh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command
go getcan no longer be used to build packages startingGo v1.18(see deprecation notice). Kustomize version also needs to be updated sincego installdoesn't support exclude directives (see issue). The change has been tested on bothGo v1.17andGo v1.18to ensure the Makefile works properly.Issue #, if available: N/A
Description of changes: Update
go gettogo install, and Kustomize version tov4.5.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.