Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump controller-runtime version to v0.14.4 #818

Closed
wants to merge 1 commit into from

Conversation

g-gaston
Copy link
Member

Description of changes:
Updates controller-runtime module and deal with all breaking changes, mostly changes in the client.Get and client.Status().Update signatures.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 10, 2023
Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: g-gaston, TerryHowe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivyostosh
Copy link
Member

/hold
Can this wait until K8 1.25 release is done?

@g-gaston
Copy link
Member Author

/hold if possible until we move to capi 1.4 since v0.14 breaking changes affected them as well
kubernetes-sigs/cluster-api#7906

@TerryHowe
Copy link
Contributor

/unhold

@TerryHowe
Copy link
Contributor

/hold

@TerryHowe
Copy link
Contributor

rebased #843

@TerryHowe TerryHowe closed this Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved do-not-merge/hold lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants