Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller Support for Worker Node Taints #1150

Closed
danbudris opened this issue Feb 4, 2022 · 1 comment
Closed

Controller Support for Worker Node Taints #1150

danbudris opened this issue Feb 4, 2022 · 1 comment
Assignees

Comments

@danbudris
Copy link
Member

danbudris commented Feb 4, 2022

The EKS-A Controller should reconcile modifications to the taints field of the workerNodeGroupConfigurations in such a way that new nodes are rolled out and tainted appropriately.

In order to provide controller support for taints, we'll need to add a mechanism by which we generate new kubeadmconfigtemplates with an update joinConfiguration containing the requisite taints, and then modify the machineDeployemnts which reference those kubeadmconfigtemplates to reference the new kubeadmconfigtemplate; this way we can trigger a rollout of the machinedeployments, causing new machines to be launched, and the updated joinConfiguration in the kubeadmconfigtemplate to go into effect. This will also address SSH key rolling.

As of right now, upstream intentionally does not support 'immutable' kubeadmconfigtemplates, but the official guidance is to treat them in the same way we treat the immutable machineTemplates -- e.g. create a new one with the updates, modify the machineDeployment to use it, trigger rollout & node recreation.

See:

Originally posted by @danbudris in #189 (comment)

@danbudris danbudris added this to the next milestone Feb 4, 2022
@danbudris danbudris self-assigned this Feb 4, 2022
@danbudris
Copy link
Member Author

support for reconciliation of taints we merged in with #1175

@jaxesn jaxesn removed this from the next milestone May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants