-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support node taints in cluster config #189
Comments
an update on this issue: In order to provide controller support for taints, we'll need to add a mechanism by which we generate new As of right now, upstream intentionally does not support 'immutable' See: |
this feature is released in 0.7.1 |
Eks a releaser
What would you like to be added:
Add node taints option in cluster config for both control plane and worker node groups. So that the defined taints can be attached to the node(s) automatically during cluster creation/upgrade.
cluster config
We add taints option at the
cluster
level, eg:implementation
Cluster API already supports taints for both control plane and machine deployment:
We might easily pass down the taints option to the CAPI spec before applying.
The CAPI taints option does not work for worker nodes (kubeadmconfigtemplates). We https://github.com/kubernetes-sigs/cluster-api/blob/main/controlplane/kubeadm/controllers/controller.go#L267might add taints for worker nodes in the CLI workflow, or as a
postKubeadmCommands
defined in thekubeadmconfigtemplates
.Why is this needed:
User requests to allow the retention of node taints during an upgrade. Currently the rolling update recreates VMs and the new nodes joined do not have the taints defined in the original nodes. User needs to manually attach those taints back after upgrade.
We'd like to provide a descriptive way to let user define node taints in the cluster config, so that the nodes being created/upgraded can have the proper taints (if defined) on the node(s) automatically without manual setup.
TODO list
NoSchedule
orNoExecute
taints #1126TBD:
The text was updated successfully, but these errors were encountered: