Remove feature flag for taints #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danbudris The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-0.7 |
|
@danbudris: once the present PR merges, I will cherry-pick it on top of release-0.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
eks-distro-bot
added
the
size/M
|
/lgtm |
|
@danbudris: #1268 failed to apply on top of branch "release-0.7": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a-cool-train
pushed a commit
to a-cool-train/eks-anywhere
that referenced
this pull request
Feb 22, 2022
* remove feature flag for taints * don't set feature flag for taints in e2e tests
mitalipaygude
pushed a commit
to mitalipaygude/eks-anywhere-1
that referenced
this pull request
Feb 23, 2022
* remove feature flag for taints * don't set feature flag for taints in e2e tests
eks-distro-bot
pushed a commit
that referenced
this pull request
Feb 24, 2022
* Include Base GetPackage * Include get package base implementation * Remove unnecessary changes * Update cmd/eksctl-anywhere/cmd/getpackage.go Co-authored-by: Terry Howe <terrylhowe@gmail.com> * Include error handling * Include feature gate * Include usage update * Include constants for flags * Resolve linting issues * Reorder imports to match gofumpt formatting * Update cmd/eksctl-anywhere/cmd/getpackage.go Co-authored-by: Vivek Koppuru <vivek.koppuru@gmail.com> * Make eksdReleaseRef a pointer to support previous releases (#1234) * Add chrisdoherty4 to owners (#1240) * End to end tests for taints (#1224) * add GetNodes method to kubectl exe * add basic test for taints upgrade * move taint generation methods to framework * refactor test to deduce node from wngc and compare taints * move methods to framework, remove uneeded check' * account for multiple machineSets on cluster after upgrade * Update internal/pkg/api/cluster.go Co-authored-by: Guillermo Gaston <guillermogastonlorente@gmail.com> * Update internal/pkg/api/cluster.go Co-authored-by: Guillermo Gaston <guillermogastonlorente@gmail.com> * Update test/framework/taints.go Co-authored-by: Guillermo Gaston <guillermogastonlorente@gmail.com> Co-authored-by: Guillermo Gaston <guillermogastonlorente@gmail.com> * Validate requested node provisioninging against available cr hardware (#1238) * Unmarshal EKS-D latest releases into typed struct instead of interface (#1246) * Make new bundle fields optional (#1221) * Add gwesterfieldjr to OWNERS (#1243) * Fix incorrect optional external etcd configuration behavior (#1250) Etcd configuration is optional when specifying a cluster spec. The code expected an external etcd configuration. This patches it to make it optional. * create tinkerbell template override struct (#1244) * Add API definition for Snow provider (#1248) * Add API definition for Snow provider * Run `make release-manifests` to auto generate snow CRDs * Add Snow CRDs to release eksa-components.yaml * Adding kubectl for cloudstack (#1219) * Adding kubectl for cloudstack * Fixing typos in kubectl.go * Responding to PR feedback * Addressing lint issues * Support node label reconciliation (#1241) * Support node label reconciliation * edit comment to labels * Fix unit tests for taints and labels * Control Plane Taints: end-to-end tests; account for applied taints (#1254) * cp taints e2e tests; worker and cp validation methods * remove unused GetKubeadmConfigTemplate method from kubectl exectuable * validate control plane taints in taints e2e tests * add control plane taint tolerations to IAM auth configuraiton * add custom control plane taint tolerations to vsphere-csi-controller * account for default CP taint * Update test/framework/workerNodes.go * Update pkg/awsiamauth/config/aws-iam-authenticator.yaml Co-authored-by: Vivek Koppuru <vivek.koppuru@gmail.com> * set taints feature flag to true on e2e test Co-authored-by: Vivek Koppuru <vivek.koppuru@gmail.com> * [PR BOT] Update ATTRIBUTION.txt file (#1253) * Create cluster in the new controller (#1199) * Create cluster in the new controller * Fix error and pass extra paramters when creating spec * Fix wrong us of log * No need to requeue in case of error * Remove unnecessary Requeue * Fix lint error * Move etcd logic before controlplane logic * Apply extra objects in a loop * Remove feature flag for taints (#1268) * remove feature flag for taints * don't set feature flag for taints in e2e tests * Remove unnecessary files * Resolve PR comments * Resolve Gofumpt issues * Resolve Gofumpt issues * Remove formatting when not necessary * Convert all options to KubectlOpt * Rename GetPackagesFromKubectl to GetPackages * Move withOutput logic to client * Update cmd/eksctl-anywhere/cmd/getpackage.go Co-authored-by: Vivek Koppuru <vivek.koppuru@gmail.com> * Simplify options * Gofumpt resolution Co-authored-by: Terry Howe <terrylhowe@gmail.com> Co-authored-by: Vivek Koppuru <vivek.koppuru@gmail.com> Co-authored-by: Taylor Neyland <57606775+taneyland@users.noreply.github.com> Co-authored-by: Chris Doherty <chris.doherty4@gmail.com> Co-authored-by: Daniel Budris <d.c.budris@gmail.com> Co-authored-by: Guillermo Gaston <guillermogastonlorente@gmail.com> Co-authored-by: Abhay Krishna <arnchlm@amazon.com> Co-authored-by: Guillermo Gaston <gaslor@amazon.com> Co-authored-by: Terry Howe <tlhowe@amazon.com> Co-authored-by: Greg Westerfield, Jr <gwesterfieldjr@gmail.com> Co-authored-by: Joey Wang <jiayiwang7@yahoo.com> Co-authored-by: Max Dribinsky <maxdrib@users.noreply.github.com> Co-authored-by: Vivek Koppuru <koppv@amazon.com> Co-authored-by: Daniel Budris <budris@amazon.com> Co-authored-by: EKS Distro PR Bot <75336432+eks-distro-pr-bot@users.noreply.github.com> Co-authored-by: Gabriel Mendes <77989267+mdsgabriel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#189
Description of changes:
Remove the feature flag for Taints and allow it to be free.
Testing (if applicable):
End-to-end tests for taints have been executed in various configurations.
Extensive manual testing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.