Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: E2E test improvements #1269

Merged

Conversation

danbudris
Copy link
Member

Issue #, if available:
#189

Description of changes:
I built on a number of changes to the E2E test framework when writing the end-to-end tests for the taints.

This PR backports a number of changes to the framework that are pre-requisites for backporting the taints e2e tests. We really need to get better about backporting stuff to the test framework as we write it.

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jiayiwang7 and others added 7 commits February 22, 2022 18:01
* Refactor GitOps e2e test to pass in testOpts, add tests for workload cluster

* Remove unused arg

* Rename upgradeGitops methods

* Remove unnecessary method

* Generate GitOpsConfig name every time when running e2e flux test

* Only generate lowercase alphanumeric string for K8s object names
* Improvements for 'upgrades from latest release' e2e tests

* Increas the timeout for kubeadm control plane ready in e2e tests

* Increased timeout for cilium retrier
Expands current e2e testing framework to support multiple worker node
groups. It allows to add/remove/update worker node groups to the initial
spec and during upgrades.

Adds one simple vSphere tests that starts with two worker node groups.
During the upgrade, it scales down one of them to 1 replica, it deletes
the other one and creates a new one.
@eks-distro-bot eks-distro-bot added approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 22, 2022
Copy link
Member

@g-gaston g-gaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danbudris, g-gaston, vivek-koppuru

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danbudris,g-gaston,vivek-koppuru]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 45dec22 into aws:release-0.7 Feb 23, 2022
@danbudris danbudris deleted the backport-taints-end-to-end-tests branch February 23, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants